r364895 - [clang][Driver][ARM] NFC: Remove unused function parameter
Alexandros Lamprineas via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 2 02:45:24 PDT 2019
Author: alelab01
Date: Tue Jul 2 02:45:24 2019
New Revision: 364895
URL: http://llvm.org/viewvc/llvm-project?rev=364895&view=rev
Log:
[clang][Driver][ARM] NFC: Remove unused function parameter
Removes a vector reference that was added by D62998, since the
preexisting function parameter is sufficient.
Differential Revision: https://reviews.llvm.org/D64044
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp?rev=364895&r1=364894&r2=364895&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp Tue Jul 2 02:45:24 2019
@@ -100,7 +100,6 @@ static void DecodeARMFeaturesFromCPU(con
static void checkARMArchName(const Driver &D, const Arg *A, const ArgList &Args,
llvm::StringRef ArchName, llvm::StringRef CPUName,
std::vector<StringRef> &Features,
- std::vector<StringRef> &ExtensionFeatures,
const llvm::Triple &Triple) {
std::pair<StringRef, StringRef> Split = ArchName.split("+");
@@ -108,7 +107,7 @@ static void checkARMArchName(const Drive
llvm::ARM::ArchKind ArchKind = llvm::ARM::parseArch(MArch);
if (ArchKind == llvm::ARM::ArchKind::INVALID ||
(Split.second.size() && !DecodeARMFeatures(
- D, Split.second, CPUName, ArchKind, ExtensionFeatures)))
+ D, Split.second, CPUName, ArchKind, Features)))
D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
}
@@ -116,7 +115,6 @@ static void checkARMArchName(const Drive
static void checkARMCPUName(const Driver &D, const Arg *A, const ArgList &Args,
llvm::StringRef CPUName, llvm::StringRef ArchName,
std::vector<StringRef> &Features,
- std::vector<StringRef> &ExtensionFeatures,
const llvm::Triple &Triple) {
std::pair<StringRef, StringRef> Split = CPUName.split("+");
@@ -125,7 +123,7 @@ static void checkARMCPUName(const Driver
arm::getLLVMArchKindForARM(CPU, ArchName, Triple);
if (ArchKind == llvm::ARM::ArchKind::INVALID ||
(Split.second.size() && !DecodeARMFeatures(
- D, Split.second, CPU, ArchKind, ExtensionFeatures)))
+ D, Split.second, CPU, ArchKind, Features)))
D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
}
@@ -361,13 +359,13 @@ void arm::getARMTargetFeatures(const Too
<< ArchArg->getAsString(Args);
ArchName = StringRef(WaArch->getValue()).substr(7);
checkARMArchName(D, WaArch, Args, ArchName, CPUName,
- Features, ExtensionFeatures, Triple);
+ ExtensionFeatures, Triple);
// FIXME: Set Arch.
D.Diag(clang::diag::warn_drv_unused_argument) << WaArch->getAsString(Args);
} else if (ArchArg) {
ArchName = ArchArg->getValue();
checkARMArchName(D, ArchArg, Args, ArchName, CPUName,
- Features, ExtensionFeatures, Triple);
+ ExtensionFeatures, Triple);
}
// Add CPU features for generic CPUs
@@ -383,7 +381,7 @@ void arm::getARMTargetFeatures(const Too
if (CPUArg)
checkARMCPUName(D, CPUArg, Args, CPUName, ArchName,
- Features, ExtensionFeatures, Triple);
+ ExtensionFeatures, Triple);
// Honor -mfpu=. ClangAs gives preference to -Wa,-mfpu=.
const Arg *FPUArg = Args.getLastArg(options::OPT_mfpu_EQ);
if (WaFPU) {
More information about the cfe-commits
mailing list