[PATCH] D64018: [clangd] Store hash of command line in index shards.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 00:44:09 PDT 2019


kadircet added a comment.

In D64018#1566085 <https://reviews.llvm.org/D64018#1566085>, @sammccall wrote:

> This makes sense but is hard to debug - is there a reason we don't just store (the relevant parts of) the actual compile command? Size?


Yes I had the size in mind, also didn't see any use case for the actual compile commands.
As for size, I suppose it is OK to store the whole command as it is only stored for the main file of a TU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64018/new/

https://reviews.llvm.org/D64018





More information about the cfe-commits mailing list