[PATCH] D62888: [NewPM] Port Sancov

[Chandler Carruth via Phabricator via cfe-commits]

chandlerc added a comment.

The used thing still seems like there is an underlynig bug here. See below.

(Also a tiny nit, but that isn't the interesting part.)



================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:206
+
+std::string getSectionStart(const Triple &TargetTriple,
+                            const std::string &Section) {
----------------
Maybe call these `getFooBarImpl` so that you don't have to rely on name lookup trickery below to refer to them unambiguously?


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:750
       Constant::getNullValue(ArrayTy), "__sancov_gen_");
+  appendToCompilerUsed(*CurModule, {Array});
 
----------------
There is a `GlobalsToAppendToCompilerUsed` vector that we append `Array` to below (line 759). Why isn't that sufficient instead of this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62888/new/

https://reviews.llvm.org/D62888