[PATCH] D61909: Add Clang shared library with C++ exports

Chris Bieneman via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 1 16:22:07 PDT 2019


The question is, what *should* it be called.

While yes, the 's' in 'so' is shared, the "dylib" and "dll" extensions on Darwin and Windows have the same meaning too. The problem is libclang.so is already taken.

I'm not attached to the name in any way, so I'm open to suggestions.

We do have documentation on best practices for how to build distributions, which includes explanations of how to pick and choose what you want to install (http://llvm.org/docs/BuildingADistribution.html <http://llvm.org/docs/BuildingADistribution.html>), so you shouldn't need an option to disable it.

-Chris

> On Jul 1, 2019, at 6:13 PM, Tom Stellard via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> tstellar added a comment.
> 
> In D61909#1563678 <https://reviews.llvm.org/D61909#1563678>, @sylvestre.ledru wrote:
> 
>> For now, it isn't part of the debian packaging.
>> https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/snapshot/debian/rules#L563
>> it is removed as packaging phase as I have been told it isn't ready.
>> 
>> Anyway, the lib should not keep this name.
>> By definition, on linux, .so means shared. It should have a more explicit name.
>> 
>> @beanz Can you please rename it? thanks
> 
> 
> I've filed a bug for this and marked it as a blocker for 9.0.0, because once we ship a release with this name, it will be harder to change: https://bugs.llvm.org/show_bug.cgi?id=42475
> 
> 
> Repository:
>  rC Clang
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D61909/new/
> 
> https://reviews.llvm.org/D61909
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190701/118fe2bd/attachment.html>


More information about the cfe-commits mailing list