[PATCH] D60974: Clang IFSO driver action.

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 1 15:03:51 PDT 2019


jfb added a comment.

In D60974#1565517 <https://reviews.llvm.org/D60974#1565517>, @jfb wrote:

> In D60974#1565054 <https://reviews.llvm.org/D60974#1565054>, @plotfi wrote:
>
> > So I think I know what may be going on on your end. The llvm-readelf in your path I believe might be the wrong lllvm-readelf (llvm-readelf-7). Are you sure you built llvm-readelf from git?
>
>
> Please don't do this. Your commit is wrong, and the right action from you is to revert it or fix it. I've fixed it for you here: rL364855 <https://reviews.llvm.org/rL364855>


I'm also really not sure this is any good: why does clang look at ELF? In general I'd expect you to test something *way* earlier than ELF. Are you sure you're testing the right thing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974





More information about the cfe-commits mailing list