[PATCH] D51262: Implement P0553 and P0556

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 1 13:11:12 PDT 2019


mclow.lists marked 2 inline comments as done.
mclow.lists added inline comments.


================
Comment at: libcxx/include/bit:208
+    const unsigned int __dig = numeric_limits<_Tp>::digits;
+    return (__cnt % __dig) == 0
+        ? __t
----------------
EricWF wrote:
> Why did you choose to use the ternary operator here, but you use an `if` in `rotr`?
Because Arthur suggested it, and said "Meh".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51262/new/

https://reviews.llvm.org/D51262





More information about the cfe-commits mailing list