[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 1 10:19:09 PDT 2019


Charusso updated this revision to Diff 207366.
Charusso marked 8 inline comments as done.
Charusso edited the summary of this revision.
Charusso added a comment.
Herald added subscribers: aheejin, dschuff.

- Revert the `Calls` option. It turned out too difficult to create. (May it useless, as we have tons of similar checkers without any option.)

- Halve the test. We do not want to catch only a call, we have to catch the class as well to prevent `error()`s like NoReturnFunctionChecker produce.

- Prunable notes added to `CheckerContext`.

- `CallDescriptionMap::lookup()` now `Optional`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63915/new/

https://reviews.llvm.org/D63915

Files:
  clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h
  clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
  clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp
  clang/test/Analysis/return-value-guaranteed.cpp
  clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63915.207366.patch
Type: text/x-patch
Size: 10162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190701/f5fb3ec8/attachment.bin>


More information about the cfe-commits mailing list