[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.





================
Comment at: clang/include/clang/AST/ASTImporter.h:331
+    ///
+    /// \return the equivalent APValue in the "from" Constext or the import
+    /// error.
----------------
typo: `Constext` -> `Context`
Also, we return with the APValue in the "to" context, not the one in the "from" context.


================
Comment at: clang/lib/AST/ASTImporter.cpp:8503
 
+llvm::Expected<APValue> ASTImporter::Import(const APValue &FromValue) {
+  APValue Result;
----------------
Looks okay, but could we have unit tests for this in ASTImporterTest.cpp?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63640/new/

https://reviews.llvm.org/D63640