[PATCH] D63954: Add lifetime categories attributes
Matthias Gehre via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 30 14:25:15 PDT 2019
mgehre marked 2 inline comments as done.
mgehre added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4560-4561
+ if(AL.getKind() == ParsedAttr::AT_Owner) {
+ if (checkAttrMutualExclusion<PointerAttr>(S, D, AL))
+ return;
+ if (const auto *Attr = D->getAttr<OwnerAttr>()) {
----------------
erik.pilkington wrote:
> This is duplicated with the first line in the function.
Removed the first line, which only checked for duplicate attributes on the same declaration, but we must check (here) that all matching
declaration are consistent - by performing all checks on the canonical declaration.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63954/new/
https://reviews.llvm.org/D63954
More information about the cfe-commits
mailing list