[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

[Csaba Dabis via Phabricator via cfe-commits]

Charusso accepted this revision.
Charusso added a comment.

Great patch, thanks you! I wanted to make my own `IdentifierInfo` array previously.



================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1060
+public:
+  const static unsigned NoArgRequirement = std::numeric_limits<unsigned>::max();
+
----------------
What about `Optional<>`? When I first met that function I have fallen in love.


================
Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:72
+          {{"foo"}, true},
+      }), "void foo(); void bar() { foo(); }"));
+
----------------
May it worth to mention the second true/false business stands for the call being called.


================
Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:103
+          {{"foo"}, true},
+      }), "void foo(); struct bar { void foo(); }; void test() { foo(); }"));
+
----------------
So `{{"bar", "foo"}, true}`? I like puzzles, but it would be cool to state out why it is negative as other tests all have negative sub-tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62441/new/

https://reviews.llvm.org/D62441