[PATCH] D63857: [clang-doc] Structured HTML generator

[Jake Ehrlich via Phabricator via cfe-commits]

jakehehrlich added a comment.

Can you upload `git diff -U100000 <commit before genHTML>` functions so that I can see the code without it being fragmented? It's hard to parse some of the more fragmented stuff here



================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:191-194
+static std::vector<std::unique_ptr<TagNode>> genHTML(const EnumInfo &I);
+static std::vector<std::unique_ptr<TagNode>> genHTML(const FunctionInfo &I);
+
+static std::vector<std::unique_ptr<TagNode>>
----------------
Never use 'static' for functions in C++. For functions anon-namespaces and 'static' mean the same thing but C++ generates a lot of stuff behind the scenes and to make those 'static' you need to use an non-namespace.

In general the rule is to put as much as you can in anon-namespaces and always prefer that for functions/globals/constants over 'static'. This is important for `constexpr` variables specifically because depending on the C++ version they don't play nice with the `static` keyword.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63857/new/

https://reviews.llvm.org/D63857