[PATCH] D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 28 02:02:50 PDT 2019


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:31
+// Contains all highlightings in a single line.
+struct LineHighlighting {
+  LineHighlighting(unsigned int Line = 0,
----------------
The structures defined here are similar to the structures proposed in LSP `SemanticHighlightingParams` and `SemanticHighlightingInformation`, we could define these structures in the `Protocol.h` (you can find similar pattern there).








Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63919/new/

https://reviews.llvm.org/D63919





More information about the cfe-commits mailing list