[PATCH] D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt
Nick Desaulniers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 27 14:22:34 PDT 2019
nickdesaulniers added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:401
+ case Stmt::GCCAsmStmtClass:
+ assert(cast<GCCAsmStmt>(Term)->isAsmGoto() == true && "Encountered GCCAsmStmt without labels");
+ // TODO: Handle jumping to labels
----------------
prefer: `assert(shouldBeTrue() && "asdfasdf")` to `assert(shouldBeTrue() == true && "asfas")`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63533/new/
https://reviews.llvm.org/D63533
More information about the cfe-commits
mailing list