[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

Please add full context to the patches (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
Also, some general comments inlined.



================
Comment at: clang/include/clang/Basic/Attr.td:1652
+  let Args = [StringArgument<"AttrName">];
+  let Documentation = [Undocumented];
+}
----------------
You will eventually need to add documentation for all three.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:761
+    }
+  }
+
----------------
Variable names: `VarName`
Comments and clang-format, please.
`assert` needs a text
Can we merge the common argument and return attribute code?
Why don't we need to parse the AttrKind for FnAttr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63845/new/

https://reviews.llvm.org/D63845