[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'
Alex Strelnikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 26 12:00:07 PDT 2019
astrelni added a comment.
In D62977#1559628 <https://reviews.llvm.org/D62977#1559628>, @lebedev.ri wrote:
> It //sounds// correct, but i don't see accompanying test changes, so i can't be sure.
The tests as they are cover the positive case in that they would not show warning or fixes if we didn't find the replacements. The only way to test the negative is to make a second test with a second set of mock googletest headers that declare things in the v1.8 way. Is this what you would prefer?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62977/new/
https://reviews.llvm.org/D62977
More information about the cfe-commits
mailing list