[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

Thanks, looks good.



================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1
+//==- SemanticHighlightingTest.cpp - SemanticHighlightTest tests-*- C++ -* -==//
+//
----------------
nit: SemanticHighlightingTest.cpp => SemanticHighlightingTests.cpp


================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:18
+
+std::vector<HighlightingToken> makeHighlightingTokens(llvm::ArrayRef<Range> Ranges,
+                                              HighlightingKind Kind) {
----------------
nit: clang-format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63559/new/

https://reviews.llvm.org/D63559