[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

[Johan Vikström via Phabricator via cfe-commits]

jvikstrom marked an inline comment as done.
jvikstrom added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlight.h:17
+
+enum class SemanticHighlightKind {
+  Variable,
----------------
hokein wrote:
> LSP proposal is using `Highlighting` rather than `Highlight`, let's align with the LSP proposal, using  `Highlighting` in our names (comments, function, class, and files).
> 
> 
> The name seems too verbose, let's drop the `Semantic`, just use `HighlightingKind`.
There is also a `DocumentHighlightingKind` enum though. Is there not a possibility of  confusing people with `HighlightingKind` and `DocumentHighlightingKind`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63559/new/

https://reviews.llvm.org/D63559