[PATCH] D63518: BitStream reader: propagate errors
    JF Bastien via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Tue Jun 25 17:12:37 PDT 2019
    
    
  
jfb added a comment.
I've addressed Lang's comments and the re-audited all the new FIXME instances. This patch now actually drops errors on the floor instead of implicitly erroring out unless the error path is tested (which is what I had before). This hides bugs, but I left FIXMEs everywhere and it means the patch will be less disruptive because it's bug-compatible in the areas that aren't tested.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63518/new/
https://reviews.llvm.org/D63518
    
    
More information about the cfe-commits
mailing list