[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

Tue Jun 25 10:25:01 PDT 2019

tra added a comment.

In D63756#1557658 <https://reviews.llvm.org/D63756#1557658>, @cdevadas wrote:

> Hi Sam,
>  The compiler generates metadata for the first 48 bytes. I compiled a sample code and verified it. The backend does nothing for the extra bytes now.
>  I will soon submit the backend patch to generate the new metadata.

Something that adds ability to handle extra args should be in place at the same time or earlier than the knob that enables the feature.
Ordering of patches matters. You don't know at which revision users will check out the tree and we do want the tree to be buildable and functional at every revision.
Even if breaking the logical order appears to be benign in this case, it would still be better to commit them in order.

I propose to wait until your upcoming patch is up for review, add it as a dependency here and land patches in the right order.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63756/new/

https://reviews.llvm.org/D63756