[PATCH] D63759: [clangd] Don't rename the namespace.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 25 03:54:46 PDT 2019


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:167
+      case UnsupportedSymbol:
+        return "not a supported symbol (e.g. namespace)";
       }
----------------
can't rename symbols of this kind?

"supported" lacks context I think.


================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137
+    // Parsing the .h file as C++ include.
+    TU.ExtraArgs.push_back("-xobjective-c++-header");
     auto AST = TU.build();
----------------
(why this change?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63759/new/

https://reviews.llvm.org/D63759





More information about the cfe-commits mailing list