[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 25 02:34:14 PDT 2019


martong marked 2 inline comments as done.
martong added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5000
   EXPECT_TRUE(ImportedOK);
 }
 
----------------
balazske wrote:
> I see now that this test is really not required, the previous test checks the almost same thing in case of `class B` and `NS` (but more test is always better).
Actually, this test belongs to the previous patch , not to this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62375/new/

https://reviews.llvm.org/D62375





More information about the cfe-commits mailing list