[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

Jian Cai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 24 13:43:07 PDT 2019


jcai19 added a comment.

In D63623#1556161 <https://reviews.llvm.org/D63623#1556161>, @lebedev.ri wrote:

> In D63623#1552716 <https://reviews.llvm.org/D63623#1552716>, @jcai19 wrote:
>
> > In D63623#1552679 <https://reviews.llvm.org/D63623#1552679>, @lebedev.ri wrote:
> >
> > > Why is this in android module?
> > >  Is that android-specific behavior, or posix?
> >
> >
> > I implemented it for Andriod as requested, but it would be completely fine to move it if it is better to place the check at a different location. Where do you suggest we should move this check to? Thanks.
>
>
> Either `misc` or `bugprone` or a new `posix` module.


Sounds good. Thanks for the clarification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63623/new/

https://reviews.llvm.org/D63623





More information about the cfe-commits mailing list