[PATCH] D63330: [clangd] Add Value field to HoverInfo

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:920
+      {R"cpp(
+        constexpr int add(int a, int b) { return a + b; }
+        int [[b^ar]] = add(1, 2);
----------------
sammccall wrote:
> constexpr may not be required here, I think?
> At least the docs suggest evaluation ignores language semantics like this.
apparently this constexpr is necessary, otherwise evaluation fails.


================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:673
          HI.Type = "Foo<int, char, bool>";
+         HI.Value = "Foo<int, char, bool>(5)";
        }},
----------------
sammccall wrote:
> are these actually still emitted, or tests not updated?
> 
> Some of them (e.g. the lambda below!) don't seem useful
oops, somehow I've deleted the expect line that checks the values :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63330/new/

https://reviews.llvm.org/D63330