[PATCH] D63666: [clang-doc] Add templates to HTML generator

Diego Astiazarán via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 21 17:16:17 PDT 2019


DiegoAstiazaran added inline comments.


================
Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:313-314
+<div>
+<div>
+<p></p>
+<p> Brief description.</p>
----------------
juliehockett wrote:
> Emitting extra div/p here? Add a check in the comment generation bit to ensure you're not emitting an empty string for ParagraphComments
The <div> is for same reason as the previous comment.
The <p> is generated by the the first child of the FullComment, it has no text.
A check for empty paragraphs has been added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63666/new/

https://reviews.llvm.org/D63666





More information about the cfe-commits mailing list