[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 21 16:43:29 PDT 2019


rnk added a comment.

In D63678#1554513 <https://reviews.llvm.org/D63678#1554513>, @ro wrote:

> Please have a look at what the autoconf manual has to say on echo vs. printf:


Yikes, fair enough.

I actually really wish lit had some support for the here-document pattern:

  cat <<EOF
  $foo
  EOF

We could replace many uses of echo in our test suite with this, but it's not clear how it interacts when prefixed with `# RUN: `, and we'd have to implement it in the builtin lit shell for Windows. I proposed a tool to extract such tagged regions from a file before, but some senior contributors opposed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63678/new/

https://reviews.llvm.org/D63678





More information about the cfe-commits mailing list