[PATCH] D63666: [clang-doc] Add templates to HTML generator

Fri Jun 21 16:29:07 PDT 2019

DiegoAstiazaran marked 2 inline comments as done.
DiegoAstiazaran added inline comments.

================
Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:307-308
+<title></title>
+<div>
+<div>
+<h3>f</h3>
----------------
juliehockett wrote:
> Emitting an extra div here?
The first div is emitted by the MainContent template.
The second div is emitted by the FunctionBlock template.
There's nothing between them because the TopLevelInfoHeader template is not rendered between them, which happens because there's no NamespaceInfo or RecordInfo.
I think we shouldn't worry about it because this won't happen in a real case. In here we're calling generateDocForInfo() with a FunctionInfo as parameter, which won't happen when the complete clang-doc is running, only RecordInfo and NamespaceInfo are passed to generateDocForInfo().

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63666/new/

https://reviews.llvm.org/D63666