[PATCH] D63227: [analyzer] Better timers.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 19 16:38:08 PDT 2019
NoQ marked an inline comment as done.
NoQ added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:228
-ExprEngine::~ExprEngine() {
- BR.FlushReports();
----------------
xazax.hun wrote:
> Hmm. Maybe add an assert that all the bug reports are flushed at this point? Just to make sure we never need this :) I am not insisting on this change just wondering.
Actually we already have the same code in `~BugReporter` itself, so this assertion would be kinda trivial. Like, it wouldn't necessarily hold, as the destructor for the field hasn't been executed at this point, but it's still useless, because the destructor will be executed very soon.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63227/new/
https://reviews.llvm.org/D63227
More information about the cfe-commits
mailing list