[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a few nits.



================
Comment at: clang/include/clang/AST/Mangle.h:253
+public:
+  ASTNameGenerator(ASTContext &Ctx);
+  bool writeName(const Decl *D, raw_ostream &OS);
----------------
Slight preference to make this constructor `explicit` since it only accepts a single argument and I can't imagine wanting a converting constructor there.


================
Comment at: clang/lib/AST/Mangle.cpp:25
 #include "llvm/ADT/StringExtras.h"
+#include "llvm/IR/Mangler.h"
 #include "llvm/Support/ErrorHandling.h"
----------------
Do we have to link in any new libraries in CMake for this new dependency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63535/new/

https://reviews.llvm.org/D63535