[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 19 10:55:27 PDT 2019


jfb added a comment.

In D63423#1550725 <https://reviews.llvm.org/D63423#1550725>, @lebedev.ri wrote:

> I've always been frustrated at how clang just gives up as soon as it sees a macro.
>  At best that should be controlled with some command-line flag.


This patch is not the place to change common clang behavior. I'm advocating for what we usually do: be conservative in macros because token-pasting tends to look "wrong" but not actually be wrong as much (i.e. false positives). If you want clang to do something different, an RFC to cfe-dev is the right place for such a discussion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63423/new/

https://reviews.llvm.org/D63423





More information about the cfe-commits mailing list