[PATCH] D63508: make -frewrite-includes handle __has_include wrapped in a macro

Tor Arne Vestbø via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 19 10:24:21 PDT 2019


torarnv added a comment.

In D63508#1550668 <https://reviews.llvm.org/D63508#1550668>, @rsmith wrote:

> Perhaps we should rewrite all `#if`-like directives to `#if 0` or `#if 1`?


If I understand your suggestion correctly, wouldn't the latter break this case?

  #if QT_HAS_INCLUDE(<nope.h>)
  #  include <nope.h>
  #  define HAS_NOPE
  #endif
  
  #ifdef HAS_NOPE
  void bar() { nope(); }
  #endif




Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63508/new/

https://reviews.llvm.org/D63508





More information about the cfe-commits mailing list