[PATCH] D63535: [clang][AST] MangleUtil: A refactoring of CodegenNameGeneratorImpl (NFC).

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added inline comments.


================
Comment at: clang/include/clang/AST/Mangle.h:19
+#include "clang/AST/DeclCXX.h"
+#include "clang/AST/DeclObjC.h"
 #include "clang/AST/Type.h"
----------------
Move these into the implementation, forward declarations should be sufficient.


================
Comment at: clang/include/clang/AST/Mangle.h:21
 #include "clang/AST/Type.h"
+#include "clang/AST/VTableBuilder.h"
 #include "clang/Basic/ABI.h"
----------------
This isn't used, it belongs in the implementation.


================
Comment at: clang/include/clang/AST/Mangle.h:25
+#include "llvm/IR/DataLayout.h"
+#include "llvm/IR/Mangler.h"
 #include "llvm/Support/Casting.h"
----------------
Is `Mangler` used in the header?  I think this can be in the implementation.


================
Comment at: clang/include/clang/AST/Mangle.h:253
+
+struct MangleUtil {
+  std::unique_ptr<MangleContext> MC;
----------------
I think I prefer `ASTNameGenerator` or even `ASTNameMangler` (though I am partial to Microsoft's term: "decoration").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63535/new/

https://reviews.llvm.org/D63535