[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 19 03:16:30 PDT 2019
gribozavr added a comment.
Thanks! Please add tests in `./unittests/Tooling/ReplacementsYamlTest.cpp`.
================
Comment at: clang/include/clang/Tooling/ReplacementsYaml.h:43
+ ReplacementText.replace(lineBreakPos, 1, "\n\n");
+ // Get the next occurrence from the current position
+ lineBreakPos = ReplacementText.find('\n', lineBreakPos + 2);
----------------
Please add comments that explain why this is the correct serialization. Please don't add comments that repeat the code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63482/new/
https://reviews.llvm.org/D63482
More information about the cfe-commits
mailing list