[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

Chandler Carruth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 18 19:39:21 PDT 2019


chandlerc added a comment.

OMG, I'm so sorry, I had no idea that the tests would explode like that... Yeah, I don't think that's useful....

Maybe a better approach is to just explicitly run the code through `opt -passes=instsimplify` before handing it to FileCheck? That should produce almost identical results to the old PM's inliner?

Feel free to just try this out and report back -- if it isn't looking good, don't invest a bunch of time in it, we should talk to Craig and figure out what the right long-term strategy here is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63174/new/

https://reviews.llvm.org/D63174





More information about the cfe-commits mailing list