[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 18 18:08:46 PDT 2019


rsmith added inline comments.


================
Comment at: include/clang/AST/DeclCXX.h:337-341
     /// true when this class is empty for traits purposes,
-    /// i.e. has no data members other than 0-width bit-fields, has no
+    /// i.e. has no data members other than 0-width bit-fields and empty
+    /// fields marked [[no_unique_address]], has no
     /// virtual function/base, and doesn't inherit from a non-empty
     /// class. Doesn't take union-ness into account.
----------------
aaron.ballman wrote:
> Do you mind re-flowing this entire comment to 80 cols?
Reflowed and turned into bulleted list for clarity.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63451/new/

https://reviews.llvm.org/D63451





More information about the cfe-commits mailing list