[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 18 09:48:36 PDT 2019


ilya-biryukov added a comment.

In D62953#1547799 <https://reviews.llvm.org/D62953#1547799>, @sammccall wrote:

> Can you explain why this is important?
>  (in the code)


I've added a few comments into the code that builds token buffers, but I couldn't figure out a good place to mention this in the API docs.
It would be a natural expectation from the API from my POV, the fact that we glued empty expansions together is an implementation artifact rather than a sensible contract...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62953/new/

https://reviews.llvm.org/D62953





More information about the cfe-commits mailing list