[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

Tue Jun 18 07:14:34 PDT 2019

aaron.ballman added a comment.

In D62952#1535088 <https://reviews.llvm.org/D62952#1535088>, @hubert.reinterpretcast wrote:

> @aaron.ballman, for similar cases in the plist output, it has been proposed
>
> - that the reference expected file be committed into the tree pre-normalized, and
> - that tool be modified such that the output file has a newline at the end of the file.
>
>   Does that sound good for this format?

In general, that seems reasonable, but I would prefer to take care of more of the work in lit.local.cfg than have to deal with that atrocious RUN line in every test case. Is there a way to retain a similarly succinct solution as diff_sarif?

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62952/new/

https://reviews.llvm.org/D62952