[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Can we add a test using TestTU that does a very basic verification of expanded/spelled tokens (first after preamble, last token in file)?



================
Comment at: clang-tools-extra/clangd/ClangdUnit.h:140
   std::unique_ptr<FrontendAction> Action;
+  /// Expanded tokens for the main file. Does not contain tokens for the file
+  /// preamble.
----------------
Not sure "expanded" is accurate here - it has both.
(And it'd be worth spelling out if expanded tokens or spelled tokens or both are missing for the preamble)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62956/new/

https://reviews.llvm.org/D62956