[PATCH] D63436: [analyzer] Fix JSON dumps for ExplodedNodes

[Csaba Dabis via Phabricator via cfe-commits]

Charusso marked 2 inline comments as done.
Charusso added a comment.

Thanks for the review!



================
Comment at: clang/test/Analysis/dump_egraph.c:3
 // RUN: cat %t.dot | FileCheck %s
-// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-dump-egraph=%t.dot -trim-egraph %s
 // REQUIRES: asserts
----------------
NoQ wrote:
> Charusso wrote:
> > This did nothing.
> Let's fix it by adding another `// RUN: cat %t.dot | FileCheck %s` after this line instead, so that both trimmed graph and untrimmed graph gets tested.
I am not sure why `Report.getErrorNode() == N` is not enough, but now it passes well and satisfies the problem when we reported something on hidden nodes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63436/new/

https://reviews.llvm.org/D63436