[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 17 15:36:30 PDT 2019


xbolva00 added a comment.

In D63423#1547244 <https://reviews.llvm.org/D63423#1547244>, @regehr wrote:

> In D63423#1547216 <https://reviews.llvm.org/D63423#1547216>, @xbolva00 wrote:
>
> > The only remaining question is, as your said, whether or not to diagnose xors in macros. @regerh @jfb ?
>
>
> IMO it's better to not warn about xors in macros-- I like the current tradeoffs.


Thank you for opinion.

I think this patch is (almost) done. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63423/new/

https://reviews.llvm.org/D63423





More information about the cfe-commits mailing list