[PATCH] D63367: [clang-doc] Add basic support for templates and typedef
Julie Hockett via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 17 12:24:16 PDT 2019
juliehockett added inline comments.
================
Comment at: clang-tools-extra/clang-doc/Representation.h:244
// interface).
+ bool IsTypeDef = false; // Indicates if record was declared using typedef
llvm::SmallVector<MemberTypeInfo, 4>
----------------
Run clang-format? Not totally sure what it'll do, but I think it should line up the comments.
================
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:387
- SymbolID ParentUSR = getUSRForDecl(D->getParent());
- Func.Parent = Reference{ParentUSR, D->getParent()->getNameAsString(),
- InfoType::IT_record};
+ const NamedDecl *Parent;
+ if (const auto *SD =
----------------
Generally, it's not a great idea to declare a pointer without initializing it. Either initialize it on declaration or initialize to nullptr.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63367/new/
https://reviews.llvm.org/D63367
More information about the cfe-commits
mailing list