[PATCH] D63369: [AST] Fixed extraneous warnings for binary conditional operator
Nick Desaulniers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 17 11:12:18 PDT 2019
nickdesaulniers added inline comments.
================
Comment at: clang/lib/AST/Expr.cpp:2348
// RHS are warnings.
const ConditionalOperator *Exp = cast<ConditionalOperator>(this);
+ return Exp->getLHS()->isUnusedResultAWarning(WarnE, Loc, R1, R2, Ctx) &&
----------------
`const auto *Exp`
================
Comment at: clang/lib/AST/Expr.cpp:2353
+ case BinaryConditionalOperatorClass: {
+ auto *Exp = cast<BinaryConditionalOperator>(this);
+ return Exp->getFalseExpr()->isUnusedResultAWarning(WarnE, Loc, R1, R2, Ctx);
----------------
`const auto *Exp`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63369/new/
https://reviews.llvm.org/D63369
More information about the cfe-commits
mailing list