[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 17 07:06:01 PDT 2019


lebedev.ri added a comment.

In D43500#1546077 <https://reviews.llvm.org/D43500#1546077>, @jdemeule wrote:

> In D43500#1244518 <https://reviews.llvm.org/D43500#1244518>, @JonasToth wrote:
>
> > What is the status here? Will you continue to work on this patch @jdemeule (which would be great!) ?
>
>
> Hi, now, this patch contains only tests which are already covered with lit tests.
>  The cleanup is now applied in clang-apply-replacements.


How does that work with `clang-tidy -fix` ?

> 
> 
> In D43500#1491369 <https://reviews.llvm.org/D43500#1491369>, @chgans wrote:
> 
>> Hi, Using llvm-8 (llvm ubuntu repo), clang-replacement has improved, but there still a case when a comma is left beyond: if there was only one member init.
> 
> 
> I do not reproduce at master (9.0.0 trunk), do you have an example in mind?




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43500/new/

https://reviews.llvm.org/D43500





More information about the cfe-commits mailing list