[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

Matthias Gehre via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 16 12:46:34 PDT 2019


mgehre marked an inline comment as done.
mgehre added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/misc-unused-parameters.c:1-7
 // RUN: %check_clang_tidy %s misc-unused-parameters %t -- -- -xc
 
 // Basic removal
 // =============
 void a(int i) {;}
 // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: parameter 'i' is unused [misc-unused-parameters]
-// CHECK-FIXES: {{^}}void a(int  /*i*/) {;}{{$}}
----------------
lebedev.ri wrote:
> This screams a separate bug to me.
> Does `%check_clang_tidy` not check that sources, after applying fix-it's, still parse?
Unfortunately, no :-(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63088/new/

https://reviews.llvm.org/D63088





More information about the cfe-commits mailing list