[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 16 10:10:23 PDT 2019


Szelethus added a comment.

In D62899#1544630 <https://reviews.llvm.org/D62899#1544630>, @NoQ wrote:

> I don't remember what exactly does `markInteresting()` do and these tests don't really convince me that it does anything at all. Halp? >.<


Damnit, forgot my actual test file in the office (did not git add it).

I wanted to just say "Well `markInteresting()` is about the same as `trackExpressionValue()`!", and while I suspect that there's some truth to that, honestly, it's explained extremely poorly in the code. As I understand it, interesting symbols and expressions are used in the pruning of the bug path, namely, if a you'd like to prune out B->C->D from bugpath A->B->C->D->E, but C is interesting, no pruning will take place.

I particularly liked your description of BugReporter.cpp as a "military grade portion of spaghetti", because thats pretty much all I could figure out. I'll try harder though, because it seems to be an important part of the bug report construction. @xazax.hun, you seem to be a lot more confident with this, is what I'm saying more or less correct?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62899/new/

https://reviews.llvm.org/D62899





More information about the cfe-commits mailing list