[PATCH] D58880: [clangd] Type hierarchy subtypes

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 15 19:28:16 PDT 2019


nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1052
+                          PathRef TUPath) {
+  // TODO: Pass in ClangdServer::WorkspaceRoot as a HintPath.
+  StringRef HintPath;
----------------
kadircet wrote:
> this part looks a little messed up ?
> 
>  I suppose you wanted to propagate TUPath to symbolToLocation right?
Good catch! Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58880/new/

https://reviews.llvm.org/D58880





More information about the cfe-commits mailing list