[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 15 19:00:18 PDT 2019


nridge added a comment.

In D63331#1543441 <https://reviews.llvm.org/D63331#1543441>, @hokein wrote:

> To avoid multiple people working on the same feature, I think the plan is that @jvikstrom will pick up the current stuff, and continue working/improving it.


Sounds good! I'm excited to see this moving forward :)

I've had a look at this patch, and it's very similar to my prototype implementation in D61842 <https://reviews.llvm.org/D61842>. Mine handles some more cases in the RecursiveASTVIsitor, especially around dependent names inside templates, and has corresponding test cases that you may want to reuse @jvikstrom.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63331/new/

https://reviews.llvm.org/D63331





More information about the cfe-commits mailing list