[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 15 08:28:28 PDT 2019


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.cpp:11
+#include "../utils/OptionsUtils.h"
+
+#include <array>
----------------
Please remove unnecessary empty line.


================
Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceMemcpyByStdCopy.cpp:86
+  // Retrieve all the arguments
+  for (uint8_t i = 0; i < 3; i++) {
+    llvm::raw_string_ostream s(arg[i]);
----------------
Please use arg,size() instead of 3.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63324/new/

https://reviews.llvm.org/D63324





More information about the cfe-commits mailing list