[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

Fri Jun 14 15:13:58 PDT 2019

hliao added a comment.

In D63335#1544428 <https://reviews.llvm.org/D63335#1544428>, @tra wrote:

> In D63335#1544324 <https://reviews.llvm.org/D63335#1544324>, @hliao wrote:
>
> > > I think debugger does have sufficient information to deal with this and that would be the right place to deal with the issue.
> >
> > em, I did push the later as well, :(. OK, I will simplify the patch to change any functionality but move the calculation of device name into a common interface. So that, vendor could adjust that internally with minimal change. OK?
>
>
> :-( Sorry about that. I realize how frustrating that can be.
>
> Perhaps it's worth trying once more. You can argue that this change will have trouble being upstreamed without a good technical explanation why it must be done in the compiler. Perhaps they do have compelling reasons why it's hard to do in the debugger, but without specific details from their end it appears indistinguishable from a (possibly misguided) quick fix. It may help if you could get the debugger folks to chime in directly on the review.

shall we review code refactoring first, so that that change could be just a single line change. Yes, I could post that later and drag in necessary stake holders.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63335/new/

https://reviews.llvm.org/D63335