[PATCH] D63362: [analyzer] Fix JSON dumps for store clusters.
Csaba Dabis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 14 15:04:46 PDT 2019
Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
Thanks you!
================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:215
+ << "{ \"cluster\": \"" << I.getKey() << "\", \"pointer\": \""
+ << ((const void *)I.getKey()) << "\", \"items\": [" << NL;
----------------
People say extra parens are bad. So as they are the root of the evil, could you remove it, please?
(I also like to emphasize same stuff packed into parens for better understanding/readability, but we are the minority.)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63362/new/
https://reviews.llvm.org/D63362
More information about the cfe-commits
mailing list