[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

[Csaba Dabis via Phabricator via cfe-commits]

Charusso marked an inline comment as done.
Charusso added inline comments.


================
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:170-171
         super(Store, self).__init__()
-        self.clusters = [StoreCluster(c) for c in json_s]
+        self.clusters = collections.OrderedDict(
+            [(c['cluster'], StoreCluster(c)) for c in json_s])
+
----------------
NoQ wrote:
> This is broken due to possible collisions in cluster keys (eg., two variables with the same name but different scopes).
> I guess i'll have to add a unique key to the cluster dump, i.e., a `MemRegion` pointer.
It is a good idea, thanks for fixing these errors!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62761/new/

https://reviews.llvm.org/D62761